WC09 final beta 4 bugs

[PugFish]

Hey Kasper and HyBreeD,
Been using final beta 4 for a few days and got a few more bugs to report.

For HyBreeD:
I've found a few more problems with the javascript parser.

This isn't going to be easy to explain When using object literals and passing one into a new object, if the parameters aren't quoted they show up as variables in the document outline even though this is valid syntax. Also any sub-object parameters show up, up until a closing } is found and then it seems to work fine.

Javascript_object_literal_problem.png (50.12 KiB) Viewed 418 times

Another problem is when using this.var in a function inside the same scenario as above causes a phantom class to show up in the document outline (i've quoted the parameters just to rule the first problem out). This is MooTools syntax for class declaration if you were wondering.

Javascript_phantom_class_problem.png (40.84 KiB) Viewed 419 times

Third problem is pictured in the screenshot above aswell, when assigning an object to a variable more than once it shows up in the document outline for each time.

For Kasper:

1. Found more dialog windows that are resizable but the controls inside them don't resize: Error report and most of the dialogs for the Tools in the Tools tool window (too many tools in that sentence ).
2. HTML inside HTML comments is still validated

And some bugs left over from my FB3 thread that weren't addressed:

1. CSS code tidy doesn't seem to obey most of the rules, only the spaces before and after the colon work.
2. CSS code tidy preview formatting in settings dialog is wrong when you first open settings, but as soon as you click a setting it fixes itself
3. Code tidy previews don't update until you move onto another setting, much better if they updated when a value is changed
4. Can't see all of HTML code tidy preview, first line is covered

And a couple of feature requests

1. When using conditional HTML comments for only having code execute in IE the whole block is coloured as a comment, but would it be possible for the contents to be highlighted as normal in this case?
2. (From FB3 thread) A code preview for syntax colouring like in code tidy instead of just "Sample text" would be very handy

[KasperTSW]

Hi,

> 1. Found more dialog windows that are resizable but the controls inside them don't resize: Error report and most of the dialogs for the Tools in the Tools tool window (too many tools in that sentence ).

Should be fixed now

> 2. HTML inside HTML comments is still validated

You're right, but that is not a very common situation, and fixing it would require too many changes in this phase of the beta test. I have added it to my TODO list for next version though

> 1. CSS code tidy doesn't seem to obey most of the rules, only the spaces before and after the colon work.

Could you please tell me where you see this issue? As far as I can tell, it works very well

> 2. CSS code tidy preview formatting in settings dialog is wrong when you first open settings, but as soon as you click a setting it fixes itself

Actually, that is by design. My intention was to show people how bad CSS could look, and how nice it could look with their selected profile. However, you are not the first one to misunderstand this, so now I've changed it to just look clean and tidy on the first show

> 3. Code tidy previews don't update until you move onto another setting, much better if they updated when a value is changed

Okay, fixed

> 4. Can't see all of HTML code tidy preview, first line is covered

Should be fixed now

> 1. When using conditional HTML comments for only having code execute in IE the whole block is coloured as a comment, but would it be possible for the contents to be highlighted as normal in this case?

It probably would, but once again, this is a pretty narrow request, and a bit late in the process, so not for now, sorry . You can play with it your self, though. Just open the HTML highlighter file (HTML.xml) and have a look

> 2. (From FB3 thread) A code preview for syntax colouring like in code tidy instead of just "Sample text" would be very handy

Currently not possible, sorry.

[PugFish]

Could you please tell me where you see this issue? As far as I can tell, it works very well

I think i've figured out most of the issues. I should have said before but this all happens when using the "Use CSS Tidy on a line/block of code...etc" options, it works fine when using it through the Functions menu. I should also say that all the CSS intellisense options are on, and some of these issues happen when used in conjunction with this.

1. If no configuration is set to default (put a * next to it in the menu) then the BracketStyle isn't obeyed when you type the opening { and it is automatically closed, but if you set a default then it works as it should. There's no default by default ( ) so it seemed like BracketStyle was never obeyed.
2. When you type a ; or } it always uses the "Default Style Block" configuration, even if you have set another configuration as default. This was my reason for thinking it wasn't working at all as I was changing the options for one configuration but it was always using the other one.
3. When you select a value from the intellisense and a ; is automatically inserted, code tidy is not applied for that line when it would have if you had typed the ;
4. When you start typing a value the intellisense pops up, but even if you never use it and type the whole value then press ; a second ; is automatically inserted as if you had used intellisense.
5. There is no option to not complete intellisense on space key, so when you press space after a : it always uses the first value in the list.
6. When you cancel the colour dialog that pops up after using [color] from the intellisense, a ; is inserted even though there's no value. Especially annoying with the issue above where typing "color: " will always pop up the colour dialog.
7. When selecting ColorType as RGB and a hex/name is converted to RGB it uses rgb(0,0,0) but after a second tidy it adds spaces after all the commas, i.e. rgb(0, 0, 0)
8. I can't figure out what SelectorIndent is supposed to do, i've not seen it change anything no matter what value I give it.
9. Not exactly a bug, but when "Automatically complete curly brackets" is enabled the block tidy never gets triggered so the selector never gets tidied. You have to manually trigger the tidy by deleting/replacing the } or through the menu. Maybe it could be triggered after the brackets are automatically completed which should also fix issue #1 (assuming #2 is fixed )

As a side note, the code tidy for all the languages let you set a default but also let you unset it. I don't really get the purpose of this as surely one should always be default? What happens when the configuration is called but no default is set?

[KasperTSW]

Hi,

> 1. If no configuration is set to default (put a * next to it in the menu) then the BracketStyle isn't obeyed when you type the opening { and it is automatically closed, but if you set a default then it works as it should. There's no default by default ( ) so it seemed like BracketStyle was never obeyed.

Yeah you're right. The default default (;)) configuration will now be the style block configuration

> 2. When you type a ; or } it always uses the "Default Style Block" configuration, even if you have set another configuration as default. This was my reason for thinking it wasn't working at all as I was changing the options for one configuration but it was always using the other one.

Nicely spotted. This should be fixed now. In the rare case where you haven't got a default configuration, it will fall back on the Default style block.

> 3. When you select a value from the intellisense and a ; is automatically inserted, code tidy is not applied for that line when it would have if you had typed the ;

For now, I won't change this - you can always disable the automatic insertion of the semicolon. I'll look into changing this for the next version

> 4. When you start typing a value the intellisense pops up, but even if you never use it and type the whole value then press ; a second ; is automatically inserted as if you had used intellisense.

Okay, that one was pretty tricky to fix, without messing up other things. The final solution is to disable ; as a valid accept key for the CSS AutoProposal list, when automatic insertion of semicolons is enabled. It's the best I can do

> 5. There is no option to not complete intellisense on space key, so when you press space after a : it always uses the first value in the list.

Actually, you can regulate this with the default CSS Code Tidy profile. If SpaceAfterColon is enabled, value proposal won't be activated directly after the colon, but instead when you add a space. With the fixes to the default config as mentioned above, this should work

> 6. When you cancel the colour dialog that pops up after using [color] from the intellisense, a ; is inserted even though there's no value. Especially annoying with the issue above where typing "color: " will always pop up the colour dialog.

Should be fixed now

> 7. When selecting ColorType as RGB and a hex/name is converted to RGB it uses rgb(0,0,0) but after a second tidy it adds spaces after all the commas, i.e. rgb(0, 0, 0)

Should be fixed as well.

> 8. I can't figure out what SelectorIndent is supposed to do, i've not seen it change anything no matter what value I give it.

For now, just consider it as "Reserved for future use"

> 9. Not exactly a bug, but when "Automatically complete curly brackets" is enabled the block tidy never gets triggered so the selector never gets tidied. You have to manually trigger the tidy by deleting/replacing the } or through the menu. Maybe it could be triggered after the brackets are automatically completed which should also fix issue #1 (assuming #2 is fixed )

Since the ending } is placed a couple of lines below the { when auto completing, there is really nothing to tidy in this case

>As a side note, the code tidy for all the languages let you set a default but also let you unset it. I don't really get the purpose of this as surely one should always be default? What happens when the configuration is called but no default is set?

You're right! That should be fixed as well now

[PugFish]

Since the ending } is placed a couple of lines below the { when auto completing, there is really nothing to tidy in this case

The problem is the selector though, it only gets tidied when a block tidy is triggered but it never is.

I was wondering if all these fixes made it into final beta 5? Some of them are fixed but i'm still getting the Default Style Block being used no matter what as well as #7.

More bugs:

1. In relation to #7, when using ColorType there's a couple of problems. Converting hex and named to anything works fine, but converting RGB to hex doesn't do anything and RGB to named causes an error.
2. When a code tidy configuration is set to default and you try to delete it nothing happens, I think it should either tell you it can't be deleted or change the default to another one and then delete it.
3. There's a fairly annoying JS intellisense problem that I haven't quite figured out, but i'll report it in case some light can be shed on what causes it. The problem is sometimes when I type "this." the intellisense pops up and selects "history", so when I press the . I end up with "thistory." being filled into the page. This doesn't happen every time, it seems to happen after I start a new line and start typing very quickly. If I type on an already blank line "this" shows in intellisense as expected.
   
   From what I can gather, the cause of this is something to do with the delay of the JS parser. After lots of testing it seems the problem gets worse the bigger the file is. Sometimes it skips 2 or 3 of the first letters, causing "isFinite" and "screen" to be selected in the list instead of "this" (the problem isn't confined to "this", it's just an example).
   
   I'm going to make a guess at what's causing this. The JS parser reparses the file every time a line is ended with ; or a new line is started (and I think after the first letter is typed on a new line?). The document outline refreshes after a parse and if the intellisense popup is open it also refreshes. Because of this refresh it then forgets the letters that were typed before and starts searching only on new letters. Bigger files take longer to parse therefore causing the intellisense to skip more letters.
4. If there is an opening quote or comment within a javascript regex, everything after it becomes highlighted as a string/comment. e.g. var regex = /this is /*a te"st/g;
5. When typing things very fast that are closed automatically sometimes the closing bracket isn't ignored, ending up with with double. e.g. ()). This also seems to get worse the bigger the file.

[PugFish]

Just noticed that types are still being highlighted as reserved words in PHP.

Also I was wondering shouldn't the settings folder under AppData be in Roaming and not Local? You'd want your settings to follow you if you moved to another machine.

[KasperTSW]

>The problem is the selector though, it only gets tidied when a block tidy is triggered but it never is.

Well, at least for now, you will either have to turn off the automatic completion of } or do the tidy manually

>I was wondering if all these fixes made it into final beta 5?

They should be in FB5, yes

>Some of them are fixed but i'm still getting the Default Style Block being used no matter what

Please write down the specific situations, so that I can look into them. As I said, Default Style Block is used as a fallback configuration, so be sure to have another default configuration when reproducing this problem

>as well as #7.

I'm thinking that you probably didn't let WebCoder upgrade it's datafiles when you installed FB5. However, a few changes were made and bug #7 should be fixed by one of these changes

> 1. In relation to #7, when using ColorType there's a couple of problems. Converting hex and named to anything works fine, but converting RGB to hex doesn't do anything and RGB to named causes an error.

I just tested this. My rgb(51,204,0) gets converted just fine into HEX, and is left alone for named colors, since there isn't one. Once again, I'm pretty sure that this is related to the datafile issue

> 2. When a code tidy configuration is set to default and you try to delete it nothing happens, I think it should either tell you it can't be deleted or change the default to another one and then delete it.

Should be fixed now

> 3. There's a fairly annoying JS intellisense problem that I haven't quite figured out, but i'll report it in case some light can be shed on what causes it. The problem is sometimes when I type "this." the intellisense pops up and selects "history", so when I press the . I end up with "thistory." being filled into the page. This doesn't happen every time, it seems to happen after I start a new line and start typing very quickly. If I type on an already blank line "this" shows in intellisense as expected.
> 5. When typing things very fast that are closed automatically sometimes the closing bracket isn't ignored, ending up with with double. e.g. ()). This also seems to get worse the bigger the file.

I made some improvements to this, which should make WebCoder work better on big files . If you want to test it, then send me an e-mail through the contact form of this site.

>4. If there is an opening quote or comment within a javascript regex, everything after it becomes highlighted as a string/comment. e.g. var regex = /this is /*a te"st/g;

I see the problem, and I will look into it, but these syntaxhighlighting problems can be damn tricky to fix

>Just noticed that types are still being highlighted as reserved words in PHP.

Please provide me with an example, and also, be sure that you have the latest datafiles from the installation

>Also I was wondering shouldn't the settings folder under AppData be in Roaming and not Local? You'd want your settings to follow you if you moved to another machine.

I'm not really sure about that. You're the first one to bring it up, so I'm thinking that the current choice works pretty well for most people

[PugFish]

I'm thinking that you probably didn't let WebCoder upgrade it's datafiles when you installed FB5. However, a few changes were made and bug #7 should be fixed by one of these changes

You're right, I reinstalled it and overwrote the settings and it's fixed those problems

Please write down the specific situations, so that I can look into them. As I said, Default Style Block is used as a fallback configuration, so be sure to have another default configuration when reproducing this problem

It's all situations Not even the curly brackets follows the default anymore. Even if I create a custom configuration and set that to default it still follows Default Style Block.

I'm not really sure about that. You're the first one to bring it up, so I'm thinking that the current choice works pretty well for most people

I suspect this is because they don't know/care When looking in the settings folder before I didn't notice it should have been roaming, but I was having a conversation with someone about Local vs Roaming the other day so I when I looked today I did notice. I don't imagine this will matter to the majority of users as they don't use roaming profiles but I think this is the "proper" place for settings.

[KasperTSW]

Hi,

>You're right, I reinstalled it and overwrote the settings and it's fixed those problems

Great

>It's all situations Not even the curly brackets follows the default anymore. Even if I create a custom configuration and set that to default it still follows Default Style Block.

My bad - I had forgotten a single ! operator in my code. Gotta hate those situations

>I suspect this is because they don't know/care When looking in the settings folder before I didn't notice it should have been roaming, but I was having a conversation with someone about Local vs Roaming the other day so I when I looked today I did notice. I don't imagine this will matter to the majority of users as they don't use roaming profiles but I think this is the "proper" place for settings.

I'll leave it as it is for now

[PugFish]

I made some improvements to this, which should make WebCoder work better on big files

It's much better now, even in an 8500 line file it's working fine

Apart from the JS parser problems I don't think I have any more bugs to report (for now)